Issue 707853003: Show a better error message for captureVisibleTab than just "internal error".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 707853003: Show a better error message for captureVisibleTab than just "internal error". (Closed)

Created:
6 years, 1 month ago by not at google - send to devlin

Modified:
6 years, 1 month ago

Reviewers:
Marijn Kruisselbrink

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Show a better error message for captureVisibleTab than just "internal error". R=mek@chromium.org Committed: https://crrev.com/da314c15d5b8f3a752f36c16742bf151f579c80d Cr-Commit-Position: refs/heads/master@{#303113}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -5 lines)			Patch
M	chrome/browser/extensions/api/tabs/tabs_api.cc	View	2 chunks	+15 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/tabs/tabs_constants.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/tabs/tabs_constants.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707853003/1

6 years, 1 month ago (2014-11-06 21:58:15 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-11-06 23:02:28 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/da314c15d5b8f3a752f36c16742bf151f579c80d
Cr-Commit-Position: refs/heads/master@{#303113}