Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs_constants.cc

Issue 707853003: Show a better error message for captureVisibleTab than just "internal error". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_constants.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/tabs/tabs_constants.h" 5 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
6 6
7 namespace extensions { 7 namespace extensions {
8 namespace tabs_constants { 8 namespace tabs_constants {
9 9
10 const char kActiveKey[] = "active"; 10 const char kActiveKey[] = "active";
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 const char kTabStripNotEditableError[] = 84 const char kTabStripNotEditableError[] =
85 "Tabs cannot be edited right now (user may be dragging a tab)."; 85 "Tabs cannot be edited right now (user may be dragging a tab).";
86 const char kNoSelectedTabError[] = "No selected tab"; 86 const char kNoSelectedTabError[] = "No selected tab";
87 const char kNoHighlightedTabError[] = "No highlighted tab"; 87 const char kNoHighlightedTabError[] = "No highlighted tab";
88 const char kIncognitoModeIsDisabled[] = "Incognito mode is disabled."; 88 const char kIncognitoModeIsDisabled[] = "Incognito mode is disabled.";
89 const char kIncognitoModeIsForced[] = "Incognito mode is forced. " 89 const char kIncognitoModeIsForced[] = "Incognito mode is forced. "
90 "Cannot open normal windows."; 90 "Cannot open normal windows.";
91 const char kURLsNotAllowedInIncognitoError[] = "Cannot open URL \"*\" " 91 const char kURLsNotAllowedInIncognitoError[] = "Cannot open URL \"*\" "
92 "in an incognito window."; 92 "in an incognito window.";
93 const char kInvalidUrlError[] = "Invalid url: \"*\"."; 93 const char kInvalidUrlError[] = "Invalid url: \"*\".";
94 const char kInternalVisibleTabCaptureError[] =
95 "Internal error while trying to capture visible region of the current tab";
96 const char kNotImplementedError[] = "This call is not yet implemented"; 94 const char kNotImplementedError[] = "This call is not yet implemented";
97 const char kSupportedInWindowsOnlyError[] = "Supported in Windows only"; 95 const char kSupportedInWindowsOnlyError[] = "Supported in Windows only";
98 const char kInvalidWindowTypeError[] = "Invalid value for type"; 96 const char kInvalidWindowTypeError[] = "Invalid value for type";
99 const char kInvalidWindowStateError[] = "Invalid value for state"; 97 const char kInvalidWindowStateError[] = "Invalid value for state";
100 const char kScreenshotsDisabled[] = "Taking screenshots has been disabled"; 98 const char kScreenshotsDisabled[] = "Taking screenshots has been disabled";
101 99
102 const char kCannotDetermineLanguageOfUnloadedTab[] = 100 const char kCannotDetermineLanguageOfUnloadedTab[] =
103 "Cannot determine language: tab not loaded"; 101 "Cannot determine language: tab not loaded";
104 102
105 } // namespace tabs_constants 103 } // namespace tabs_constants
106 } // namespace extensions 104 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_constants.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698