Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 707713006: Update Chromium for webrtc r7656. (Closed)

Created:
6 years, 1 month ago by Peter Kasting
Modified:
6 years, 1 month ago
Reviewers:
Avi (use Gerrit), Wez
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update Chromium for webrtc r7656. BUG=81439 TEST=none Committed: https://crrev.com/f9567f85788355bf3da8df030cbc232421d00b7d Cr-Commit-Position: refs/heads/master@{#303153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/ipc_socket_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/protocol/chromium_socket_factory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/test/fake_socket_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/test/fake_socket_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Peter Kasting
avi: content/ OWNERS wez: remoting/ OWNERS
6 years, 1 month ago (2014-11-06 22:06:10 UTC) #2
Avi (use Gerrit)
As per http://crbug.com/138542, you should use uint16_t and not uint16.
6 years, 1 month ago (2014-11-06 22:10:03 UTC) #3
Peter Kasting
On 2014/11/06 22:10:03, Avi wrote: > As per http://crbug.com/138542, you should use uint16_t and not ...
6 years, 1 month ago (2014-11-06 22:13:52 UTC) #4
Wez
remoting/ LGTM
6 years, 1 month ago (2014-11-06 22:14:47 UTC) #5
Avi (use Gerrit)
On 2014/11/06 22:13:52, Peter Kasting wrote: > On 2014/11/06 22:10:03, Avi wrote: > > As ...
6 years, 1 month ago (2014-11-06 22:22:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707713006/1
6 years, 1 month ago (2014-11-06 22:24:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 01:27:31 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 01:28:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9567f85788355bf3da8df030cbc232421d00b7d
Cr-Commit-Position: refs/heads/master@{#303153}

Powered by Google App Engine
This is Rietveld 408576698