Issue 707633005: Minor cleanup of ViewManagerServiceImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 707633005: Minor cleanup of ViewManagerServiceImpl (Closed)

Created:
6 years, 1 month ago by sky

Modified:
6 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Minor cleanup of ViewManagerServiceImpl Removes override of OnConnectionEstablished and puts into Init() function. R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4bf7f06e3bb45067e7c208a48a0ba2afa18b7670

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -30 lines)			Patch
M	mojo/services/view_manager/connection_manager.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_service_impl.h	View	3 chunks	+5 lines, -7 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_service_impl.cc	View	3 chunks	+18 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

6 years, 1 month ago (2014-11-07 15:46:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4bf7f06e3bb45067e7c208a48a0ba2afa18b7670 (presubmit successful).

Expand Messages | Collapse Messages