Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: mojo/services/view_manager/connection_manager.cc

Issue 707633005: Minor cleanup of ViewManagerServiceImpl (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/services/view_manager/view_manager_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/view_manager/connection_manager.cc
diff --git a/mojo/services/view_manager/connection_manager.cc b/mojo/services/view_manager/connection_manager.cc
index f093dca06575cbe68ffecd4ec59c94c7dad2d0d2..d5916eef03210ebbabb9bc6a1c9f6275f1d5d38d 100644
--- a/mojo/services/view_manager/connection_manager.cc
+++ b/mojo/services/view_manager/connection_manager.cc
@@ -139,10 +139,10 @@ void ConnectionManager::EmbedAtView(
creator_id,
creator_url,
url.To<std::string>(),
- ViewIdFromTransportId(transport_view_id),
- service_provider.Pass());
+ ViewIdFromTransportId(transport_view_id));
AddConnection(connection);
WeakBindToPipe(connection, pipe.handle0.Pass());
+ connection->Init(service_provider.Pass());
OnConnectionMessagedClient(connection->id());
}
@@ -362,10 +362,10 @@ void ConnectionManager::Create(ApplicationConnection* connection,
kInvalidConnectionId,
std::string(),
std::string("mojo:window_manager"),
- RootViewId(),
- InterfaceRequest<ServiceProvider>());
+ RootViewId());
AddConnection(window_manager_vm_service_);
WeakBindToRequest(window_manager_vm_service_, &request);
+ window_manager_vm_service_->Init(InterfaceRequest<ServiceProvider>());
}
void ConnectionManager::Create(
« no previous file with comments | « no previous file | mojo/services/view_manager/view_manager_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698