minidump/minidump_crashpad_info_writer_test.cc - Issue 707543002: MinidumpLocationDescriptorListWriter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_crashpad_info_writer_test.cc

Issue 707543002: MinidumpLocationDescriptorListWriter (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_crashpad_info_writer_test.cc

diff --git a/minidump/minidump_crashpad_info_writer_test.cc b/minidump/minidump_crashpad_info_writer_test.cc

index 3fcb2e06507f5f21a74ed10bcca45550df9bf472..2840d348240194097bbef65285862c25f53397b6 100644

--- a/minidump/minidump_crashpad_info_writer_test.cc

+++ b/minidump/minidump_crashpad_info_writer_test.cc

@@ -97,7 +97,7 @@ TEST(MinidumpCrashpadInfoWriter, CrashpadModuleList) {

const MinidumpModuleCrashpadInfo* module =

MinidumpWritableAtLocationDescriptor<MinidumpModuleCrashpadInfo>(

- file_writer.string(), module_list->modules[0]);

+ file_writer.string(), module_list->children[0]);

ASSERT_TRUE(module);

EXPECT_EQ(MinidumpModuleCrashpadInfo::kVersion, module->version);

« no previous file with comments | « minidump/minidump.gyp ('k') | minidump/minidump_extensions.h » ('j') | no next file with comments »