minidump/minidump.gyp - Issue 707543002: MinidumpLocationDescriptorListWriter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump.gyp

Issue 707543002: MinidumpLocationDescriptorListWriter (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump.gyp

diff --git a/minidump/minidump.gyp b/minidump/minidump.gyp

index ceaf951f69ecce8a6c2ec73baa46d4e7f42c1b1e..7dfcd51de39a3d336ee24037d4c673aa4000125c 100644

--- a/minidump/minidump.gyp

+++ b/minidump/minidump.gyp

@@ -41,6 +41,8 @@

'minidump_extensions.h',

'minidump_file_writer.cc',

'minidump_file_writer.h',

+ 'minidump_location_descriptor_list_writer.cc',

+ 'minidump_location_descriptor_list_writer.h',

'minidump_memory_writer.cc',

'minidump_memory_writer.h',

'minidump_misc_info_writer.cc',

@@ -85,6 +87,7 @@

'minidump_crashpad_info_writer_test.cc',

'minidump_exception_writer_test.cc',

'minidump_file_writer_test.cc',

+ 'minidump_location_descriptor_list_writer_test.cc',

'minidump_memory_writer_test.cc',

'minidump_misc_info_writer_test.cc',

'minidump_module_crashpad_info_writer_test.cc',

@@ -99,6 +102,8 @@

'test/minidump_context_test_util.h',

'test/minidump_file_writer_test_util.cc',

'test/minidump_file_writer_test_util.h',

+ 'test/minidump_location_descriptor_list_test_util.cc',

+ 'test/minidump_location_descriptor_list_test_util.h',

'test/minidump_memory_writer_test_util.cc',

'test/minidump_memory_writer_test_util.h',

'test/minidump_string_writer_test_util.cc',

« no previous file with comments | « no previous file | minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »