Fail noisily when git auto-svn can't authenticate.

Fail noisily when git auto-svn can't authenticate.

R=agable@chromium.org
BUG=N/A

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293277

[tandrii(chromium), 2014-11-17 11:35:10]

PTAL

forgot to send immediately :(

[agable, 2014-11-17 19:00:46]

https://codereview.chromium.org/707233002/diff/1/git_auto_svn.py
File git_auto_svn.py (right):

https://codereview.chromium.org/707233002/diff/1/git_auto_svn.py#newcode84
git_auto_svn.py:84: print 'Hint: maybe follow
https://chromium-access.appspot.com/ ?'
This could be waaaay more descriptive. If you're going to have it fail noisily,
say something like
print 'Authentication failed:'
print e
print 'Try running "svn ls %s" with the password from
https://chromium-access.appspot.com' % maybe_repo

[tandrii_google, 2014-12-01 22:25:33]

tandrii@google.com changed reviewers:
+ tandrii@google.com

[tandrii_google, 2014-12-01 22:25:34]

https://codereview.chromium.org/707233002/diff/1/git_auto_svn.py
File git_auto_svn.py (right):

https://codereview.chromium.org/707233002/diff/1/git_auto_svn.py#newcode84
git_auto_svn.py:84: print 'Hint: maybe follow
https://chromium-access.appspot.com/ ?'
On 2014/11/17 19:00:46, agable wrote:
> This could be waaaay more descriptive. If you're going to have it fail
noisily,
> say something like
> print 'Authentication failed:'
> print e
> print 'Try running "svn ls %s" with the password from
> https://chromium-access.appspot.com % maybe_repo

Done.

[tandrii_google, 2014-12-01 22:25:38]

PTAL

[agable, 2014-12-05 22:09:21]

lgtm

[tandrii_google, 2014-12-05 22:53:08]

The CQ bit was checked by tandrii@google.com

[commit-bot: I haz the power, 2014-12-05 22:54:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/707233002/20001

[commit-bot: I haz the power, 2014-12-05 22:56:22]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293277