Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: git_auto_svn.py

Issue 707233002: Fail noisily when git auto-svn can't authenticate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: More descriptive message. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_auto_svn.py
diff --git a/git_auto_svn.py b/git_auto_svn.py
index 4faa9a0d5c2bc3133e67260bddbe648384aa1b32..8aed18f6d6eb876b616ba6e235f5efdbfc6f58f8 100755
--- a/git_auto_svn.py
+++ b/git_auto_svn.py
@@ -78,7 +78,13 @@ def main(argv):
svn_repo = maybe_repo
svn_path = '/'.join(path_components[i+1:])
break
- except subprocess2.CalledProcessError:
+ except subprocess2.CalledProcessError, e:
+ if 'E170001' in str(e):
+ print 'Authentication failed:'
+ print e
+ print ('Try running "svn ls %s" with the password'
+ ' from https://chromium-access.appspot.com' % maybe_repo)
+ print
continue
assert svn_repo is not None, 'Unable to find svn repo for %s' % match.group(1)
print 'Found upstream svn repo %s and path %s' % (svn_repo, svn_path)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698