components/password_manager/core/browser/password_manager_driver.h - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_driver.h

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests, respond to review comments, cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/content/browser/content_credential_manager_dispatcher.cc ('K') | « components/password_manager/core/browser/password_manager_client.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_driver.h

diff --git a/components/password_manager/core/browser/password_manager_driver.h b/components/password_manager/core/browser/password_manager_driver.h

index 6e01c55a80c892a2ded956075f51026a1f600e94..9d5ca68a9449f698e481acc855fb65e9b4a9f5b1 100644

--- a/components/password_manager/core/browser/password_manager_driver.h

+++ b/components/password_manager/core/browser/password_manager_driver.h

@@ -34,13 +34,6 @@ class PasswordManagerDriver {

virtual void FillPasswordForm(

const autofill::PasswordFormFillData& form_data) = 0;

- // Returns whether any SSL certificate errors were encountered as a result of

- // the last page load.

- virtual bool DidLastPageLoadEncounterSSLErrors() = 0;

- // If this browsing session should not be persisted.

- virtual bool IsOffTheRecord() = 0;

// Informs the driver that |form| can be used for password generation.

virtual void AllowPasswordGenerationForForm(

const autofill::PasswordForm& form) = 0;