components/password_manager/content/browser/content_credential_manager_dispatcher.cc - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests, respond to review comments, cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_popup_controller_impl.cc ('K') | « components/password_manager.gypi ('k') | components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_credential_manager_dispatcher.cc

diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher.cc

index fc498d707ce9e06f57bc4d240d92192006f003fa..153c032e845c36538f9e3cf47a1f1c4a676af0b8 100644

--- a/components/password_manager/content/browser/content_credential_manager_dispatcher.cc

+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher.cc

@@ -7,6 +7,8 @@

#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"

#include "components/autofill/core/common/password_form.h"

+#include "components/password_manager/content/browser/content_password_manager_driver.h"

+#include "components/password_manager/content/browser/content_password_manager_driver_factory.h"

#include "components/password_manager/content/browser/credential_manager_password_form_manager.h"

#include "components/password_manager/content/common/credential_manager_messages.h"

#include "components/password_manager/content/common/credential_manager_types.h"

@@ -66,8 +68,12 @@ void ContentCredentialManagerDispatcher::OnNotifySignedIn(

// TODO(mkwst): This is a stub; we should be checking the PasswordStore to

// determine whether or not the credential exists, and calling UpdateLogin

// accordingly.

- form_manager_.reset(

- new CredentialManagerPasswordFormManager(client_, *form, this));

+ // TODO(estade): should pass the proper PasswordManagerDriver.

vabr (Chromium) 2014/11/17 15:08:49 Do you still need this TODO(estade)? Looks like th

Evan Stade 2014/11/17 20:34:39 correct, removed

+ form_manager_.reset(new CredentialManagerPasswordFormManager(

+ client_,

+ ContentPasswordManagerDriverFactory::FromWebContents(web_contents())

+ ->GetDriverForFrame(web_contents()->GetMainFrame()),

+ *form, this));

web_contents()->GetRenderViewHost()->Send(

new CredentialManagerMsg_AcknowledgeSignedIn(