components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests, respond to review comments, cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/content/browser/content_credential_manager_dispatcher.cc ('K') | « components/password_manager/content/browser/content_credential_manager_dispatcher.cc ('k') | components/password_manager/content/browser/content_password_manager_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

index bdefff8df7d1ffe8717ef33622e3202997ac8f50..94b330dce571211b3d669b1b10c26a6854906513 100644

--- a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

@@ -39,10 +39,6 @@ class TestPasswordManagerClient

return store_;

}

- password_manager::PasswordManagerDriver* GetDriver() override {

- return &driver_;

- }

bool PromptUserToSavePassword(

scoped_ptr<password_manager::PasswordFormManager> manager) override {

did_prompt_user_to_save_ = true;

@@ -59,7 +55,6 @@ class TestPasswordManagerClient

private:

bool did_prompt_user_to_save_;

password_manager::PasswordStore* store_;

- password_manager::StubPasswordManagerDriver driver_;

scoped_ptr<password_manager::PasswordFormManager> manager_;

};