Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5798)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/content/renderer/page_click_tracker.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tests, respond to review comments, cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/autofill/autofill_popup_controller_impl.cc ('K') | « components/autofill/content/renderer/page_click_tracker.h ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | components/password_manager/content/browser/content_credential_manager_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/page_click_tracker.cc
diff --git a/components/autofill/content/renderer/page_click_tracker.cc b/components/autofill/content/renderer/page_click_tracker.cc
index 590e7af922f1e06548c03dfd3e0190c00ee297d3..14ceda82fd5420864ff561f546dbe7aeb7f84229 100644
--- a/components/autofill/content/renderer/page_click_tracker.cc
+++ b/components/autofill/content/renderer/page_click_tracker.cc
@@ -75,6 +75,10 @@ PageClickTracker::PageClickTracker(content::RenderView* render_view,
PageClickTracker::~PageClickTracker() {
}
+void PageClickTracker::OnDestruct() {
+ // No-op. Don't delete |this|.
+}
+
void PageClickTracker::DidHandleMouseEvent(const WebMouseEvent& event) {
if (event.type != WebInputEvent::MouseDown ||
event.button != WebMouseEvent::ButtonLeft) {
« chrome/browser/ui/autofill/autofill_popup_controller_impl.cc ('K') | « components/autofill/content/renderer/page_click_tracker.h ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | components/password_manager/content/browser/content_credential_manager_dispatcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698