chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests, respond to review comments, cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_popup_controller_impl.cc ('K') | « chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc ('k') | chrome/browser/ui/login/login_prompt.h » ('j') | components/password_manager/content/browser/content_credential_manager_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

diff --git a/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc b/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

index 67bcc377e27217a1112380285041d3b7ef7aa1ff..7789f67fcfab17563197da1cbb5c119a64070ada 100644

--- a/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

+++ b/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

@@ -25,8 +25,9 @@ class TestPasswordGenerationPopupController :

gfx::RectF(0, 0, 10, 10),

PasswordForm(),

10,

- NULL /* PasswordManager*/,

- NULL /* PasswordGenerationPopupObserver*/,

+ nullptr /* PasswordManager*/,

+ nullptr /* PasswordManagerDriver*/,

+ nullptr /* PasswordGenerationPopupObserver*/,

web_contents,

native_view) {}