Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mem leak Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
index fd148d0c5499842ec2b46b2d72b85a54ac8d8b22..f5950aa886687cf75dbaf46cc20cb69b80e5d0bd 100644
--- a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
@@ -42,10 +42,6 @@ class TestPasswordManagerClient
return store_;
}
- password_manager::PasswordManagerDriver* GetDriver() override {
- return &driver_;
- }
-
bool PromptUserToSavePassword(
scoped_ptr<password_manager::PasswordFormManager> manager) override {
did_prompt_user_to_save_ = true;
@@ -78,7 +74,6 @@ class TestPasswordManagerClient
bool did_prompt_user_to_save_;
bool did_prompt_user_to_choose_;
password_manager::PasswordStore* store_;
- password_manager::StubPasswordManagerDriver driver_;
scoped_ptr<password_manager::PasswordFormManager> manager_;
};
@@ -104,6 +99,7 @@ class ContentCredentialManagerDispatcherTest
client_.reset(new TestPasswordManagerClient(store_.get()));
dispatcher_.reset(
new ContentCredentialManagerDispatcher(web_contents(), client_.get()));
+ dispatcher_->set_password_manager_driver(&stub_driver_);
NavigateAndCommit(GURL("https://example.com/test.html"));
@@ -130,6 +126,7 @@ class ContentCredentialManagerDispatcherTest
scoped_refptr<TestPasswordStore> store_;
scoped_ptr<ContentCredentialManagerDispatcher> dispatcher_;
scoped_ptr<TestPasswordManagerClient> client_;
+ StubPasswordManagerDriver stub_driver_;
};
TEST_F(ContentCredentialManagerDispatcherTest,

Powered by Google App Engine
This is Rietveld 408576698