Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mem leak Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_credential_manager_dispatcher.cc
diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher.cc
index 94e95e10a20ffe3ba99910e9d1c94bc7ec6f8cac..aae4f345c24f97302b8ffb34aed704a9528944cc 100644
--- a/components/password_manager/content/browser/content_credential_manager_dispatcher.cc
+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher.cc
@@ -8,6 +8,8 @@
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "components/autofill/core/common/password_form.h"
+#include "components/password_manager/content/browser/content_password_manager_driver.h"
+#include "components/password_manager/content/browser/content_password_manager_driver_factory.h"
#include "components/password_manager/content/browser/credential_manager_password_form_manager.h"
#include "components/password_manager/content/common/credential_manager_messages.h"
#include "components/password_manager/content/common/credential_manager_types.h"
@@ -24,8 +26,14 @@ ContentCredentialManagerDispatcher::ContentCredentialManagerDispatcher(
PasswordManagerClient* client)
: WebContentsObserver(web_contents),
client_(client),
+ driver_(nullptr),
pending_request_id_(0) {
DCHECK(web_contents);
+
+ ContentPasswordManagerDriverFactory* driver_factory =
+ ContentPasswordManagerDriverFactory::FromWebContents(web_contents);
+ if (driver_factory)
+ driver_ = driver_factory->GetDriverForFrame(web_contents->GetMainFrame());
}
ContentCredentialManagerDispatcher::~ContentCredentialManagerDispatcher() {}
@@ -68,7 +76,7 @@ void ContentCredentialManagerDispatcher::OnNotifySignedIn(
// determine whether or not the credential exists, and calling UpdateLogin
// accordingly.
form_manager_.reset(
- new CredentialManagerPasswordFormManager(client_, *form, this));
+ new CredentialManagerPasswordFormManager(client_, driver_, *form, this));
web_contents()->GetRenderViewHost()->Send(
new CredentialManagerMsg_AcknowledgeSignedIn(

Powered by Google App Engine
This is Rietveld 408576698