Refactor Autofill for out of process iframes (OOPIF).

components/password_manager/content/browser/content_credential_manager_dispatcher.cc

Index: components/password_manager/content/browser/content_credential_manager_dispatcher.cc
diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher.cc
index fc498d707ce9e06f57bc4d240d92192006f003fa..3612fd311f92513c17ff439d5f49f4e069955009 100644
--- a/components/password_manager/content/browser/content_credential_manager_dispatcher.cc
+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher.cc
@@ -66,8 +66,9 @@ void ContentCredentialManagerDispatcher::OnNotifySignedIn(
   // TODO(mkwst): This is a stub; we should be checking the PasswordStore to
   // determine whether or not the credential exists, and calling UpdateLogin
   // accordingly.
-  form_manager_.reset(
-      new CredentialManagerPasswordFormManager(client_, *form, this));
+  // TODO(estade): should pass the proper PasswordManagerDriver.

[vabr (Chromium), 2014/11/10 14:34:40]

I checked with mkwst@ (author of the credential manager code), and he says the
intent here was for the credential manager only to work with the main frame. So
in the current state the code should work fine, and maybe you want to amend the
TODO(estade) to say that "proper" driver actually means the main frame driver.

[Evan Stade, 2014/11/14 23:25:50]

thanks for figuring that out. Updated the code.

+  form_manager_.reset(new CredentialManagerPasswordFormManager(
+      client_, client_->GetDriver(), *form, this));
 
   web_contents()->GetRenderViewHost()->Send(
       new CredentialManagerMsg_AcknowledgeSignedIn(