Refactor Autofill for out of process iframes (OOPIF).

components/password_manager/content/browser/content_credential_manager_dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/content_credential_manager_dispatcher.h"
 
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/content/browser/credential_manager_password_form_manager.h"
@@ skipping 48 matching lines @@
     int request_id,
     const password_manager::CredentialInfo& credential) {
   DCHECK(request_id);
   scoped_ptr<autofill::PasswordForm> form(
       CreatePasswordFormFromCredentialInfo(credential,
           web_contents()->GetLastCommittedURL().GetOrigin()));
 
   // TODO(mkwst): This is a stub; we should be checking the PasswordStore to
   // determine whether or not the credential exists, and calling UpdateLogin
   // accordingly.
-  form_manager_.reset(
-      new CredentialManagerPasswordFormManager(client_, *form, this));
+  // TODO(estade): should pass the proper PasswordManagerDriver.

[vabr (Chromium), 2014/11/10 14:34:40]

I checked with mkwst@ (author of the credential manager code), and he says the
intent here was for the credential manager only to work with the main frame. So
in the current state the code should work fine, and maybe you want to amend the
TODO(estade) to say that "proper" driver actually means the main frame driver.

[Evan Stade, 2014/11/14 23:25:50]

thanks for figuring that out. Updated the code.

+  form_manager_.reset(new CredentialManagerPasswordFormManager(
+      client_, client_->GetDriver(), *form, this));
 
   web_contents()->GetRenderViewHost()->Send(
       new CredentialManagerMsg_AcknowledgeSignedIn(
           web_contents()->GetRenderViewHost()->GetRoutingID(), request_id));
 }
 
 void ContentCredentialManagerDispatcher::OnProvisionalSaveComplete() {
   DCHECK(form_manager_);
   client_->PromptUserToSavePassword(form_manager_.Pass());
 }
@@ skipping 54 matching lines @@
           pending_request_id_,
           info));
   pending_request_id_ = 0;
 }
 
 PasswordStore* ContentCredentialManagerDispatcher::GetPasswordStore() {
   return client_ ? client_->GetPasswordStore() : nullptr;
 }
 
 }  // namespace password_manager