Issue 706953003: Delete unused methods/arguments from RenderBlockFlow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 706953003: Delete unused methods/arguments from RenderBlockFlow. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Delete unused methods/arguments from RenderBlockFlow. No change in behavior. Just deleting dead code. Removes hit testing and paint phase for floats. They bottomed out into empty functions. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3db9471ae80bd492f2a346113d2323ba8eee0c09

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -165 lines)			Patch
M	sky/engine/core/rendering/GraphicsContextAnnotator.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/PaintPhase.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderBlock.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlock.cpp	View	4 chunks	+1 line, -9 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockFlow.h	View	3 chunks	+30 lines, -38 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockFlow.cpp	View	6 chunks	+5 lines, -69 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockLineLayout.cpp	View	3 chunks	+8 lines, -11 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayer.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderObject.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderObject.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/rendering/line/BreakingContextInlineHeaders.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/line/LineWidth.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/rendering/line/LineWidth.cpp	View	3 chunks	+7 lines, -15 lines	0 comments	Download

Total messages: 4 (1 generated)

ojan

6 years, 1 month ago (2014-11-06 19:17:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3db9471ae80bd492f2a346113d2323ba8eee0c09.