Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 706903004: Revert of Add subscribeUniform extension pipeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation.cc
diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc
index 4f5254bbebd07a07af95eca8436bfec8117fd30c..66d8c2bb13c288a9342e8ee2f9094bacdf1f66bf 100644
--- a/gpu/command_buffer/client/gles2_implementation.cc
+++ b/gpu/command_buffer/client/gles2_implementation.cc
@@ -2364,11 +2364,6 @@
GLsizei /* n */, const GLuint* /* queries */) {
}
-void GLES2Implementation::GenValuebuffersCHROMIUMHelper(
- GLsizei /* n */,
- const GLuint* /* valuebuffers */) {
-}
-
// NOTE #1: On old versions of OpenGL, calling glBindXXX with an unused id
// generates a new resource. On newer versions of OpenGL they don't. The code
// related to binding below will need to change if we switch to the new OpenGL
@@ -2518,26 +2513,6 @@
return changed;
}
-bool GLES2Implementation::BindValuebufferCHROMIUMHelper(GLenum target,
- GLuint valuebuffer) {
- bool changed = false;
- switch (target) {
- case GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM:
- if (bound_valuebuffer_ != valuebuffer) {
- bound_valuebuffer_ = valuebuffer;
- changed = true;
- }
- break;
- default:
- changed = true;
- break;
- }
- // TODO(gman): There's a bug here. If the target is invalid the ID will not be
- // used even though it's marked it as used here.
- GetIdHandler(id_namespaces::kValuebuffers)->MarkAsUsedForBind(valuebuffer);
- return changed;
-}
-
bool GLES2Implementation::UseProgramHelper(GLuint program) {
bool changed = false;
if (current_program_ != program) {
@@ -2654,11 +2629,6 @@
}
}
-void GLES2Implementation::DeleteTexturesStub(GLsizei n,
- const GLuint* textures) {
- helper_->DeleteTexturesImmediate(n, textures);
-}
-
void GLES2Implementation::DeleteVertexArraysOESHelper(
GLsizei n, const GLuint* arrays) {
vertex_array_object_manager_->DeleteVertexArrays(n, arrays);
@@ -2676,27 +2646,9 @@
helper_->DeleteVertexArraysOESImmediate(n, arrays);
}
-void GLES2Implementation::DeleteValuebuffersCHROMIUMHelper(
- GLsizei n,
- const GLuint* valuebuffers) {
- if (!GetIdHandler(id_namespaces::kValuebuffers)
- ->FreeIds(this, n, valuebuffers,
- &GLES2Implementation::DeleteValuebuffersCHROMIUMStub)) {
- SetGLError(GL_INVALID_VALUE, "glDeleteValuebuffersCHROMIUM",
- "id not created by this context.");
- return;
- }
- for (GLsizei ii = 0; ii < n; ++ii) {
- if (valuebuffers[ii] == bound_valuebuffer_) {
- bound_valuebuffer_ = 0;
- }
- }
-}
-
-void GLES2Implementation::DeleteValuebuffersCHROMIUMStub(
- GLsizei n,
- const GLuint* valuebuffers) {
- helper_->DeleteValuebuffersCHROMIUMImmediate(n, valuebuffers);
+void GLES2Implementation::DeleteTexturesStub(
+ GLsizei n, const GLuint* textures) {
+ helper_->DeleteTexturesImmediate(n, textures);
}
void GLES2Implementation::DisableVertexAttribArray(GLuint index) {
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.h ('k') | gpu/command_buffer/client/gles2_implementation_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698