Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 703203004: [telemetry] When launching an application elevated, check if it has NOPASSWD in sudoers. (Closed)

Created:
6 years, 1 month ago by dtu
Modified:
6 years, 1 month ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] When launching an application elevated, check if it has NOPASSWD in sudoers. Checking if the current process is elevated is not sufficient, because sudoers can grant permissions for specific apps. Also use the full path for sudo. BUG=420615 Committed: https://crrev.com/273f963bb4b7bcafa351d2eae82a05ccaa8ee9e0 Cr-Commit-Position: refs/heads/master@{#303176}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Use sudo -l. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 5 chunks +9 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/posix_platform_backend.py View 1 2 1 chunk +17 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dtu
6 years, 1 month ago (2014-11-07 00:37:07 UTC) #2
tonyg
lgtm assuming this works on both linux & mac
6 years, 1 month ago (2014-11-07 02:27:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703203004/40001
6 years, 1 month ago (2014-11-07 02:28:57 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-07 03:24:37 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 03:25:22 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/273f963bb4b7bcafa351d2eae82a05ccaa8ee9e0
Cr-Commit-Position: refs/heads/master@{#303176}

Powered by Google App Engine
This is Rietveld 408576698