Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7065079: Remove FileSystemURLRequestJob suppressions, as the only still-leaky (Closed)

Created:
9 years, 6 months ago by adamk
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Remove FileSystemURLRequestJob suppressions, as the only still-leaky parts are now covered by existing LeakyLazyInstance issue. R=thestig@chromium.org,timurrrr@chromium.org,glider@chromium.org BUG=80002, 83345 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89195

Patch Set 1 #

Total comments: 4

Patch Set 2 : Moved to a generic LeakyLazyInstance suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 2 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
9 years, 6 months ago (2011-06-04 20:10:24 UTC) #1
timurrrr%chromium.org
http://codereview.chromium.org/7065079/diff/1/tools/valgrind/memcheck/suppressions.txt File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/7065079/diff/1/tools/valgrind/memcheck/suppressions.txt#newcode862 tools/valgrind/memcheck/suppressions.txt:862: } Maybe we should add a generic LeakyLazyInstance suppression ...
9 years, 6 months ago (2011-06-06 08:23:45 UTC) #2
adamk
http://codereview.chromium.org/7065079/diff/1/tools/valgrind/memcheck/suppressions.txt File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/7065079/diff/1/tools/valgrind/memcheck/suppressions.txt#newcode862 tools/valgrind/memcheck/suppressions.txt:862: } On 2011/06/06 08:23:45, timurrrr%chromium.org wrote: > Maybe we ...
9 years, 6 months ago (2011-06-06 17:58:59 UTC) #3
adamk
Ping? On Mon, Jun 6, 2011 at 10:58 AM, <adamk@chromium.org> wrote: > > http://codereview.chromium.**org/7065079/diff/1/tools/**valgrind/memcheck/ > ...
9 years, 6 months ago (2011-06-13 20:55:44 UTC) #4
Alexander Potapenko
9 years, 6 months ago (2011-06-15 15:46:45 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698