Remove FileSystemURLRequestJob suppressions, as the only still-leaky

tools/valgrind/memcheck/suppressions.txt

 # There are three kinds of suppressions in this file.
 # 1. third party stuff we have no control over
 #
 # 2. intentional unit test errors, or stuff that is somehow a false positive
 # in our own code, or stuff that is so trivial it's not worth fixing
 #
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 # Periodically we should sweep this file and the bug tracker clean by
 # running overnight and removing outdated bugs/suppressions.
@@ skipping 841 matching lines @@
    fun:_Znw*
    ...
    fun:_ZN4base*Histogram10FactoryGet*
 }
 {
    # Histograms are used on un-joined threads, and can't be deleted atexit.
    Histograms via FactoryGet including Stats for disk_cache
    Memcheck:Leak
    fun:_Znw*
    fun:_ZN10disk_cache14StatsHistogram10FactoryGet*
 }

[timurrrr%chromium.org, 2011/06/06 08:23:45]

Maybe we should add a generic LeakyLazyInstance suppression here?

[adamk, 2011/06/06 17:58:59]

Done.  Let me know if I should be formatting/wildcarding this differently.

 
 #-----------------------------------------------------------------------
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 
 {
    # Chromium flakily leaks tasks at shutdown, see
    # http://crbug.com/6532
    # http://codereview.chromium.org/20067
    # http://codereview.chromium.org/42083
@@ skipping 3364 matching lines @@
    fun:_ZN8notifier26ProxyResolvingClientSocketC1ERK13scoped_refptrIN3net23URLRequestContextGetterEERKNS2_9SSLConfigERKNS2_12HostPortPairE
    fun:_ZN8notifier23XmppClientSocketFactory27CreateTransportClientSocketERKN3net12HostPortPairE
    fun:_ZN8notifier17ChromeAsyncSocket7ConnectERKN9talk_base13SocketAddressE
    fun:_ZN4buzz10XmppClient21ProcessStartXmppLoginEv
    fun:_ZN4buzz10XmppClient7ProcessEi
    fun:_ZN9talk_base4Task4StepEv
    fun:_ZN9talk_base10TaskRunner16InternalRunTasksEb
    fun:_ZN9talk_base10TaskRunner8RunTasksEv
 }
 {
-   bug_80002a
-   Memcheck:Leak
-   fun:_Znw*
-   ...
-   fun:*FileSystemURLRequestJobTest5SetUpEv
-}
-{
-   bug_80002b
-   Memcheck:Leak
-   fun:_Znw*
-   ...
-   fun:*FileSystemDirURLRequestJobTest5SetUpEv
-}
-{
    bug_80022
    Memcheck:Leak
    fun:_Znw*
    fun:_ZN3net12CertVerifier6VerifyEPNS_15X509CertificateERKSsiPNS_16CertVerifyResultEP14CallbackRunnerI6Tuple1IiEEPPv
    fun:_ZN3net25SingleRequestCertVerifier6VerifyEPNS_15X509CertificateERKSsiPNS_16CertVerifyResultEP14CallbackRunnerI6Tuple1IiEE
    fun:_ZN3net18SSLClientSocketNSS12DoVerifyCertEi
    fun:_ZN3net18SSLClientSocketNSS15DoHandshakeLoopEi
    fun:_ZN3net18SSLClientSocketNSS7ConnectEP14CallbackRunnerI6Tuple1IiEE
    fun:_ZN3net13SSLConnectJob12DoSSLConnectEv
    fun:_ZN3net13SSLConnectJob6DoLoopEi
@@ skipping 227 matching lines @@
    fun:_ZN13ThreadWatcher13StartWatchingERKN13BrowserThread2IDERKSsRKN4base9TimeDeltaES9_
    fun:_ZN17ThreadWatcherList16StartWatchingAllEv
    fun:_Z18DispatchToFunctionIPFvvEEvT_RK6Tuple0
    fun:_ZN16RunnableFunctionIPFvvE6Tuple0E3RunEv
    fun:_ZN12_GLOBAL__N_118TaskClosureAdapter3RunEv
    fun:_ZN4base8internal8Invoker1ILb0ENS0_15InvokerStorage1IMN12_GLOBAL__N_118TaskClosureAdapterEFvvEPS4_EES6_E8DoInvokeEPNS0_18InvokerStorageBaseE
    fun:_ZNK4base8CallbackIFvvEE3RunEv
    fun:_ZN11MessageLoop7RunTaskERKNS_11PendingTaskE
 }
 {
+   bug_83345
+   Memcheck:Leak
+   ...
+   fun:_ZNSt5dequeIN7leveldb12_GLOBAL__N_111ChromiumEnv6BGItemESaIS3_EEC1Ev

[timurrrr%chromium.org, 2011/06/06 08:23:45]

see the other comment

[adamk, 2011/06/06 17:58:59]

Done.

+   fun:_ZN7leveldb12_GLOBAL__N_111ChromiumEnvC1Ev
+   fun:_ZN4base25DefaultLazyInstanceTraitsIN7leveldb12_GLOBAL__N_111ChromiumEnvEE3NewEPv
+   fun:_ZN4base23LeakyLazyInstanceTraitsIN7leveldb12_GLOBAL__N_111ChromiumEnvEE3NewEPv
+   fun:_ZN4base12LazyInstanceIN7leveldb12_GLOBAL__N_111ChromiumEnvENS_23LeakyLazyInstanceTraitsIS3_EEE7PointerEv
+   fun:_ZN7leveldb3Env7DefaultEv
+   fun:_ZN7leveldb7OptionsC1Ev
+}
+{
    bug_83430
    Memcheck:Leak
    fun:_Znw*
    fun:_ZN27ScopedRunnableMethodFactoryI13ThreadWatcherE17NewRunnableMethodIMS0_FvyEyEEP14CancelableTaskT_RKT0_
    fun:_ZN13ThreadWatcher15PostPingMessageEv
    fun:_Z16DispatchToMethodI13ThreadWatcherMS0_FvvEEvPT_T0_RK6Tuple0
    fun:_ZN27ScopedRunnableMethodFactoryI13ThreadWatcherE14RunnableMethodIMS0_FvvE6Tuple0E3RunEv
    fun:_ZN12_GLOBAL__N_118TaskClosureAdapter3RunEv
    fun:_ZN4base8internal8Invoker1ILb0ENS0_15InvokerStorage1IMN12_GLOBAL__N_118TaskClosureAdapterEFvvEPS4_EES6_E8DoInvokeEPNS0_18InvokerStorageBaseE
    fun:_ZNK4base8CallbackIFvvEE3RunEv
@@ skipping 167 matching lines @@
 }
 {
    bug_todo_getdelim2
    Memcheck:Leak
    fun:malloc
    fun:getdelim
    obj:/lib/libselinux.so.1
    obj:/lib/libselinux.so.1
    obj:/lib/libselinux.so.1
 }