Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 70633002: [NaCl SDK] Run browser tests with --disable-component-update (Closed)

Created:
7 years, 1 month ago by jvoung (off chromium)
Modified:
7 years, 1 month ago
Reviewers:
binji, Sam Clegg
CC:
chromium-reviews
Visibility:
Public.

Description

[NaCl SDK] Run browser tests with --disable-component-update The PNaCl installer is more aggressive right now and checks for updates on each pexe load. Disable this behavior to test the copy of PNaCl that is already built instead of downloading the "official" one. A separate CL will make this less aggressive, but it's not clear if that will be flexible enough to detect pre-built copies of PNaCl vs official copies. E.g., if it's just based on min_version vs cur_version of official copies then it will ignore the pre-built copies. Re-enable nacl_io_test. It was timing out before because of the installation delay. The installation delay is less now due to component updater timer tweaks (2 seconds), but having --disable-component-update reduces that to 0. BUG=315253 NOTRY=true (sdk only) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234638

Patch Set 1 #

Patch Set 2 : browser_flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M native_client_sdk/src/build_tools/test_projects.py View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvoung (off chromium)
7 years, 1 month ago (2013-11-12 19:16:43 UTC) #1
Sam Clegg
So we were seeing timeouts at 40 seconds. Are you saying that even without this ...
7 years, 1 month ago (2013-11-12 19:26:06 UTC) #2
Sam Clegg
Our convention is [NaCl SDK] (with a space) in the CL description.
7 years, 1 month ago (2013-11-12 19:26:47 UTC) #3
jvoung (off chromium)
On 2013/11/12 19:26:06, Sam Clegg wrote: > So we were seeing timeouts at 40 seconds. ...
7 years, 1 month ago (2013-11-12 19:31:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/70633002/30001
7 years, 1 month ago (2013-11-12 21:12:03 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 21:23:15 UTC) #6
Message was sent while issue was closed.
Change committed as 234638

Powered by Google App Engine
This is Rietveld 408576698