Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: native_client_sdk/src/build_tools/test_projects.py

Issue 70633002: [NaCl SDK] Run browser tests with --disable-component-update (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: browser_flag Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/test_projects.py
diff --git a/native_client_sdk/src/build_tools/test_projects.py b/native_client_sdk/src/build_tools/test_projects.py
index 0fcc3ca570bb2f9e522394d10b8a4bdd21d3f1ca..5123c3c9c428f1c0889875bf866bc1f181904dae 100755
--- a/native_client_sdk/src/build_tools/test_projects.py
+++ b/native_client_sdk/src/build_tools/test_projects.py
@@ -67,10 +67,6 @@ DISABLED_TESTS = [
# TODO(binji): figure out a way to inject the testing code without
# modifying the example; maybe an extension?
{'name': 'part1'},
- # TODO(binji): loading nacl_io_test.pexe on win/linux is > 40 seconds.
- # See http://crbug.com/315253
- {'name': 'nacl_io_test', 'platform': ('win', 'linux'),
- 'toolchain': 'pnacl', 'config': 'Release'},
]
def ValidateToolchains(toolchains):
@@ -108,6 +104,8 @@ def GetBrowserTesterCommand(desc, toolchain, config):
# Prevent the infobar that shows up when requesting filesystem quota.
'--browser_flag', '--unlimited-storage',
'--enable_sockets',
+ # Prevent installing a new copy of PNaCl.
+ '--browser_flag', '--disable-component-update',
]
args.extend(['--serving_dir', GetServingDirForProject(desc)])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698