Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 706123005: Remove nop ScriptWrappable::init calls (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove nop ScriptWrappable::init calls These calls don't do anything. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f849c98190cba277e33b9f2ef520f4abdf812a0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -200 lines) Patch
M sky/engine/bindings/core/v8/ScriptWrappable.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/animation/AnimationEffect.h View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/engine/core/animation/AnimationNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationNodeTiming.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/animation/AnimationPlayer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationTimeline.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSMatrix.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSRuleList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSStyleDeclaration.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSStyleSheet.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/DOMWindowCSS.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/FontFace.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/FontFaceSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/FontFaceSetLoadEvent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/MediaList.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/MediaQueryList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/MediaQueryListEvent.h View 4 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/StyleMedia.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StyleSheet.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StyleSheetList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Attr.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/CharacterData.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/ClientRect.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/ClientRectList.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/DOMError.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/DOMException.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DOMSettableTokenList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DOMStringList.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DOMTokenList.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DOMURL.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DocumentFragment.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/MutationObserver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/MutationRecord.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/NodeList.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Range.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Text.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Touch.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/TouchList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/DOMSelection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/AnimationEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/AnimationPlayerEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/CompositionEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/CustomEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/events/ErrorEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/Event.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/EventTarget.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/events/EventTarget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/FocusEvent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/HashChangeEvent.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/KeyboardEvent.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/events/MouseEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/PageTransitionEvent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/PopStateEvent.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/ProgressEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/ResourceProgressEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/events/TextEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/TouchEvent.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/events/TransitionEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/UIEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/WheelEvent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/Console.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/History.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/ImageBitmap.cpp View 5 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Location.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Screen.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLContentElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLImageElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLImportElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLScriptElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLShadowElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLStyleElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLTemplateElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLTitleElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/ImageData.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/TextMetrics.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/ANGLEInstancedArrays.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/Canvas2DContextAttributes.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/CanvasGradient.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/canvas/CanvasPattern.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/DataView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/EXTBlendMinMax.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/EXTFragDepth.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/EXTShaderTextureLOD.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/EXTTextureFilterAnisotropic.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESElementIndexUint.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESStandardDerivatives.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESTextureFloat.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESTextureFloatLinear.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESTextureHalfFloat.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESTextureHalfFloatLinear.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESVertexArrayObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/Path2D.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLActiveInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLBuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLCompressedTextureATC.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLCompressedTextureETC1.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLCompressedTexturePVRTC.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLCompressedTextureS3TC.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLContextAttributes.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLContextEvent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLDebugRendererInfo.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLDebugShaders.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLDepthTexture.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLDrawBuffers.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLFramebuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLLoseContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLProgram.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderbuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderingContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLShader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLShaderPrecisionFormat.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLTexture.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLUniformLocation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLVertexArrayObjectOES.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/ime/InputMethodContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-11 00:39:57 UTC) #1
abarth-chromium
Committed patchset #1 (id:1) manually as f849c98190cba277e33b9f2ef520f4abdf812a0a.
6 years, 1 month ago (2014-11-11 00:41:33 UTC) #2
eseidel
6 years, 1 month ago (2014-11-11 00:45:49 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698