Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Side by Side Diff: sky/engine/core/dom/CharacterData.h

Issue 706123005: Remove nop ScriptWrappable::init calls (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/dom/Attr.cpp ('k') | sky/engine/core/dom/ClientRect.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 StringImpl* dataImpl() { return m_data.impl(); } 50 StringImpl* dataImpl() { return m_data.impl(); }
51 51
52 void parserAppendData(const String&); 52 void parserAppendData(const String&);
53 53
54 protected: 54 protected:
55 CharacterData(TreeScope& treeScope, const String& text, ConstructionType typ e) 55 CharacterData(TreeScope& treeScope, const String& text, ConstructionType typ e)
56 : Node(&treeScope, type) 56 : Node(&treeScope, type)
57 , m_data(!text.isNull() ? text : emptyString()) 57 , m_data(!text.isNull() ? text : emptyString())
58 { 58 {
59 ASSERT(type == CreateOther || type == CreateText || type == CreateEditin gText); 59 ASSERT(type == CreateOther || type == CreateText || type == CreateEditin gText);
60 ScriptWrappable::init(this);
61 } 60 }
62 61
63 void setDataWithoutUpdate(const String& data) 62 void setDataWithoutUpdate(const String& data)
64 { 63 {
65 ASSERT(!data.isNull()); 64 ASSERT(!data.isNull());
66 m_data = data; 65 m_data = data;
67 } 66 }
68 void didModifyData(const String& oldValue); 67 void didModifyData(const String& oldValue);
69 68
70 String m_data; 69 String m_data;
71 70
72 private: 71 private:
73 virtual bool isCharacterDataNode() const override final { return true; } 72 virtual bool isCharacterDataNode() const override final { return true; }
74 virtual int maxCharacterOffset() const override final; 73 virtual int maxCharacterOffset() const override final;
75 virtual bool offsetInCharacters() const override final; 74 virtual bool offsetInCharacters() const override final;
76 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, RecalcStyleBehavior = DoNotRecalcStyle); 75 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, RecalcStyleBehavior = DoNotRecalcStyle);
77 76
78 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check. 77 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check.
79 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check. 78 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check.
80 }; 79 };
81 80
82 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode()); 81 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode());
83 82
84 } // namespace blink 83 } // namespace blink
85 84
86 #endif // CharacterData_h 85 #endif // CharacterData_h
OLDNEW
« no previous file with comments | « sky/engine/core/dom/Attr.cpp ('k') | sky/engine/core/dom/ClientRect.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698