Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 706013005: Cherry pick two CLs back to M39 to fix a bug (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, amineer
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m39
Project:
skia
Visibility:
Public.

Description

Cherry pick two CLs back to M39 to fix a bug Bug fix for cull_line in SkDashPathEffect. Review URL: https://codereview.chromium.org/703783002 Crop the fast path dashed lines to the cull rect Review URL: https://codereview.chromium.org/699623003 BUG=428296 R=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/e12770148a7d170e4845ebfae75ac38ae9cf4f32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -18 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M gm/dashing.cpp View 5 chunks +97 lines, -10 lines 0 comments Download
M include/core/SkMatrix.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDashPathEffect.cpp View 3 chunks +120 lines, -3 lines 0 comments Download
M src/utils/SkDashPath.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
6 years, 1 month ago (2014-11-11 14:11:13 UTC) #2
robertphillips
6 years, 1 month ago (2014-11-11 14:11:54 UTC) #4
bsalomon
lgtm
6 years, 1 month ago (2014-11-11 14:15:38 UTC) #5
robertphillips1
6 years, 1 month ago (2014-11-11 14:18:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e12770148a7d170e4845ebfae75ac38ae9cf4f32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698