Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 705953002: Script streaming: turn off cached data to prevent crashes. (Closed)

Created:
6 years, 1 month ago by marja
Modified:
6 years, 1 month ago
Reviewers:
haraken, Mike West
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Script streaming: turn off cached data to prevent crashes. Cached data was turned on by r184826, and it seems we're producing invalid cached data. Disabling the cached data for now; this needs to be debugged before enabling it again. In addition, it can be that we try to invoke streaming for already loaded async scripts; handle that gracefully too. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8ScriptRunner.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
haraken, ptal. mkwst, could you review; this would be needed for getting a canary...
6 years, 1 month ago (2014-11-06 11:46:27 UTC) #2
Mike West
On 2014/11/06 11:46:27, marja wrote: > haraken, ptal. > > mkwst, could you review; this ...
6 years, 1 month ago (2014-11-06 11:47:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705953002/1
6 years, 1 month ago (2014-11-06 11:48:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 184911
6 years, 1 month ago (2014-11-06 13:06:59 UTC) #6
haraken
6 years, 1 month ago (2014-11-06 17:18:05 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698