Source/bindings/core/v8/ScriptStreamer.cpp - Issue 705953002: Script streaming: turn off cached data to prevent crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptStreamer.cpp

Issue 705953002: Script streaming: turn off cached data to prevent crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/ScriptStreamer.cpp

diff --git a/Source/bindings/core/v8/ScriptStreamer.cpp b/Source/bindings/core/v8/ScriptStreamer.cpp

index a769cc4677cc7ced8db1d0c562ccb83a5e720c90..ae7a28746e76edc3fa5f412748b85450a8ec0458 100644

--- a/Source/bindings/core/v8/ScriptStreamer.cpp

+++ b/Source/bindings/core/v8/ScriptStreamer.cpp

@@ -506,7 +506,8 @@ bool ScriptStreamer::startStreamingInternal(PendingScript& script, Settings* set

return false;

ScriptResource* resource = script.resource();

- ASSERT(!resource->isLoaded());

+ if (resource->isLoaded())

+ return false;

if (!resource->url().protocolIsInHTTPFamily())

return false;

if (resource->resourceToRevalidate()) {

« no previous file with comments | « no previous file | Source/bindings/core/v8/V8ScriptRunner.cpp » ('j') | no next file with comments »