Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 705843004: Remove SK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER. (Closed)

Created:
6 years, 1 month ago by bungeman-skia
Modified:
6 years, 1 month ago
Reviewers:
djsollen, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove SK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER. This removes the old guarded code and enables the new api introduced with "Update fontMgr to take list of bcp47 language tags." c20386e3937d3d398ac9b35f9c7d997e972ade98 . Blink on Android is already using the new code. Committed: https://skia.googlesource.com/skia/+/c9232dcda016feb2d30abb51483b3b1862775f84

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -109 lines) Patch
M gm/fontmgr.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M include/ports/SkFontMgr.h View 2 chunks +0 lines, -10 lines 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/ports/SkRemotableFontMgr.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkFontHost.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M src/fonts/SkFontMgr_indirect.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 chunk +25 lines, -34 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M src/ports/SkRemotableFontMgr_win_dw.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
bungeman-skia
The issue this was designed to fix has been marked as verified.
6 years, 1 month ago (2014-11-10 20:21:20 UTC) #2
tomhudson
lgtm
6 years, 1 month ago (2014-11-10 20:39:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705843004/1
6 years, 1 month ago (2014-11-10 20:40:23 UTC) #5
commit-bot: I haz the power
Presubmit check for 705843004-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 1 month ago (2014-11-10 20:40:31 UTC) #7
djsollen
lgtm
6 years, 1 month ago (2014-11-10 20:55:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705843004/1
6 years, 1 month ago (2014-11-10 20:56:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/537)
6 years, 1 month ago (2014-11-10 21:01:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705843004/20001
6 years, 1 month ago (2014-11-10 21:21:49 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 21:29:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c9232dcda016feb2d30abb51483b3b1862775f84

Powered by Google App Engine
This is Rietveld 408576698