Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 705753002: android_webview: force libstdc++ use on host. (Closed)

Created:
6 years, 1 month ago by Torne
Modified:
6 years, 1 month ago
Reviewers:
benm (inactive)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: force libstdc++ use on host. The way we build host binaries in the android gyp backend currently doesn't work if we attempt to link against libc++. To avoid problems for AOSP work to change the default C++ library, explicitly specify that we want to use libstdc++ (the current default). BUG= NOTRY=true Committed: https://crrev.com/8beb670cff7f4c09fb6f48b122efea1dff3e8803 Cr-Commit-Position: refs/heads/master@{#302784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/common.gypi View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
6 years, 1 month ago (2014-11-05 11:43:03 UTC) #2
benm (inactive)
lgtm
6 years, 1 month ago (2014-11-05 11:49:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705753002/1
6 years, 1 month ago (2014-11-05 12:16:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 12:16:48 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 12:17:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8beb670cff7f4c09fb6f48b122efea1dff3e8803
Cr-Commit-Position: refs/heads/master@{#302784}

Powered by Google App Engine
This is Rietveld 408576698