chrome/browser/translate/translate_manager.cc - Issue 7057053: Escaping file names correctly. Also fixed a crush in chromeos debug build while saving a web page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 7057053: Escaping file names correctly. Also fixed a crush in chromeos debug build while saving a web page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Missed fix. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/translate/translate_manager.cc

diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc

index e3a4f4ab60f4197725b6c5858741a76865a7f2f0..38e832525ddbaa19a556336df9c2d9317ea3d0cf 100644

--- a/chrome/browser/translate/translate_manager.cc

+++ b/chrome/browser/translate/translate_manager.cc

@@ -499,7 +499,7 @@ void TranslateManager::ReportLanguageDetectionError(TabContents* tab_contents) {

GURL page_url = tab_contents->controller().GetActiveEntry()->url();

std::string report_error_url(kReportLanguageDetectionErrorURL);

report_error_url += "?client=cr&action=langidc&u=";

- report_error_url += EscapeUrlEncodedData(page_url.spec());

+ report_error_url += EscapeUrlEncodedData(page_url.spec(), true);

report_error_url += "&sl=";

TranslateTabHelper* helper = TabContentsWrapper::GetCurrentWrapperForContents(

« no previous file with comments | « chrome/browser/sync/engine/net/url_translator.cc ('k') | chrome/common/net/gaia/gaia_auth_fetcher.cc » ('j') | no next file with comments »