No need for subtree recalc for :-internal-spatial-navigation-focus.

No need for subtree recalc for :-internal-spatial-navigation-focus.

Make the pseudo class a skippable component. This selector is for internal
use only, and currently there are no selectors in UA stylesheets that will
cause style invalidation with that pseudo class. Still, there is no need to
have it in the list of selectors requiring subtree recalc.

We do not support testing internal properties in layout tests since there
is no api for injecting UA style, but I have added a test that relies on a
current bug (see prose in the test itself).

R=chrishtr@chromium.org,esprehn@chromium.org
BUG=432440
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185284

[rune, 2014-11-12 09:15:31]

Based on top of https://codereview.chromium.org/684993007

[esprehn, 2014-11-12 18:12:32]

Does anyone ever use this? If it's not in UA sheets why can't we just delete it
instead?

[rune, 2014-11-12 20:59:36]

On 2014/11/12 at 18:12:32, esprehn wrote:
> Does anyone ever use this? If it's not in UA sheets why can't we just delete
it instead?

It's used in html.css, but the selector
"option:-internal-spatial-navigation-focus" will not contribute to any
invalidation sets.

[chrishtr, 2014-11-12 21:10:04]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2014-11-12 21:10:07]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2014-11-12 21:10:07]

lgtm

[commit-bot: I haz the power, 2014-11-12 21:11:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/705693005/1

[commit-bot: I haz the power, 2014-11-12 21:11:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-12 21:11:32]

Failed to apply patch for Source/core/css/RuleFeature.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/RuleFeature.cpp
  Hunk #1 succeeded at 142 (offset -3 lines).
  Hunk #2 FAILED at 175.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/css/RuleFeature.cpp.rej

Patch:       Source/core/css/RuleFeature.cpp
Index: Source/core/css/RuleFeature.cpp
diff --git a/Source/core/css/RuleFeature.cpp b/Source/core/css/RuleFeature.cpp
index
421987966d109a606b0789fc71d49bc26f15d875..f607cd728d0fd1bb6ee5c343f25a3b4259107a8e
100644
--- a/Source/core/css/RuleFeature.cpp
+++ b/Source/core/css/RuleFeature.cpp
@@ -145,6 +145,7 @@ static bool supportsInvalidation(CSSSelector::PseudoType
type)
     case CSSSelector::PseudoContent:
     case CSSSelector::PseudoHost:
     case CSSSelector::PseudoShadow:
+    case CSSSelector::PseudoSpatialNavigationFocus:
     case CSSSelector::PseudoListBox:
         return true;
     case CSSSelector::PseudoNotParsed:
@@ -174,7 +175,6 @@ static bool requiresSubtreeInvalidation(const CSSSelector&
selector)
     switch (selector.pseudoType()) {
     case CSSSelector::PseudoFirstLine:
     case CSSSelector::PseudoFirstLetter:
-    case CSSSelector::PseudoSpatialNavigationFocus:
         // FIXME: Most pseudo classes/elements above can be supported and moved
         // to assertSupportedPseudo(). Move on a case-by-case basis. If they
         // require subtree invalidation, document why.

[rune, 2014-11-12 21:34:45]

On 2014/11/12 at 09:15:31, rune wrote:
> Based on top of https://codereview.chromium.org/684993007

Needs this, or a rebase first.

[rune, 2014-11-13 09:14:49]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-11-13 09:14:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/705693005/1

[commit-bot: I haz the power, 2014-11-13 10:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-13 10:59:35]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36282)

[rune, 2014-11-13 11:33:01]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-11-13 11:33:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/705693005/1

[commit-bot: I haz the power, 2014-11-13 12:11:52]

Committed patchset #1 (id:1) as 185284