Support style invalidation for ::cue selectors.

Support style invalidation for ::cue selectors.

Don't resort to subtree recalc in the presence of ::cue, ::cue(), :past
and :future selectors. Traverse the selector list in ::cue() to find
invalidation set features.

The test for the ::cue element yields a recalc for more than two elements
because ::cue is currently a PseudoWebKitCustomElement, and other such
elements are present as part of the shadow DOM for video elements.

R=esprehn@chromium.org,chrishtr@chromium.org
BUG=432110
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185255

[rune, 2014-11-12 21:35:43]

rune@opera.com changed reviewers:
+ fs@opera.com

[rune, 2014-11-12 21:35:44]

Added fs in case we need a Track/VTT expert.

[chrishtr, 2014-11-12 21:36:41]

chrishtr@chromium.org changed reviewers:
- fs@opera.com

[chrishtr, 2014-11-12 21:36:42]

https://codereview.chromium.org/684993007/diff/1/Source/core/css/RuleFeature.cpp
File Source/core/css/RuleFeature.cpp (right):

https://codereview.chromium.org/684993007/diff/1/Source/core/css/RuleFeature....
Source/core/css/RuleFeature.cpp:409: ASSERT(current->pseudoType() ==
CSSSelector::PseudoHost || current->pseudoType() == CSSSelector::PseudoAny ||
current->pseudoType() == CSSSelector::PseudoNot || current->pseudoType() ==
CSSSelector::PseudoCue);
This code is repeated 3 times at line 219, 347 and 409. Factor into a helper.

[rune, 2014-11-12 22:14:02]

On 2014/11/12 at 21:36:42, chrishtr wrote:
>
https://codereview.chromium.org/684993007/diff/1/Source/core/css/RuleFeature.cpp
> File Source/core/css/RuleFeature.cpp (right):
> 
>
https://codereview.chromium.org/684993007/diff/1/Source/core/css/RuleFeature....
> Source/core/css/RuleFeature.cpp:409: ASSERT(current->pseudoType() ==
CSSSelector::PseudoHost || current->pseudoType() == CSSSelector::PseudoAny ||
current->pseudoType() == CSSSelector::PseudoNot || current->pseudoType() ==
CSSSelector::PseudoCue);
> This code is repeated 3 times at line 219, 347 and 409. Factor into a helper.

Done.

[chrishtr, 2014-11-12 22:15:54]

lgtm

https://codereview.chromium.org/684993007/diff/20001/Source/core/css/RuleFeat...
File Source/core/css/RuleFeature.cpp (right):

https://codereview.chromium.org/684993007/diff/20001/Source/core/css/RuleFeat...
Source/core/css/RuleFeature.cpp:205: return pseudo == CSSSelector::PseudoHost
Alphabetical would be nice.

[rune, 2014-11-12 22:20:28]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-11-12 22:20:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684993007/40001

[commit-bot: I haz the power, 2014-11-12 23:44:01]

Committed patchset #3 (id:40001) as 185255