Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 705633002: Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe (Closed)

Created:
6 years, 1 month ago by Rémi Piotaix
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe (patchset #8 id:140001 of https://codereview.chromium.org/613673005/) Reason for revert: The patch is breaking the telemetry blink build on some windows configurations Original issue's description: > Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe > > Depend on https://codereview.chromium.org/663233002 > > BUG=skia:2947 > > Committed: https://skia.googlesource.com/skia/+/687732fe046c9cfec940f2d7f661cd97651d10a8 > > Committed: https://skia.googlesource.com/skia/+/9bb7539a59ab15749fe26fecfec05330cffae684 BUG=skia:2947, 426708 Committed: https://skia.googlesource.com/skia/+/2bf8d09689715eaa84deebe11b62d987013923c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -177 lines) Patch
M include/utils/SkDeferredCanvas.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 3 chunks +3 lines, -39 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 6 chunks +6 lines, -88 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Rémi Piotaix
Created Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe
6 years, 1 month ago (2014-11-04 20:11:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705633002/1
6 years, 1 month ago (2014-11-04 20:13:31 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-04 20:13:32 UTC) #6
Rémi Piotaix
PTAL
6 years, 1 month ago (2014-11-04 20:14:23 UTC) #8
Justin Novosad
On 2014/11/04 20:14:23, Rémi Piotaix wrote: > PTAL lgtm
6 years, 1 month ago (2014-11-04 21:20:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705633002/1
6 years, 1 month ago (2014-11-04 21:21:17 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 21:21:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 2bf8d09689715eaa84deebe11b62d987013923c3

Powered by Google App Engine
This is Rietveld 408576698