Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe

Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe

Depend on https://codereview.chromium.org/663233002

BUG=skia:2947
Committed: https://skia.googlesource.com/skia/+/687732fe046c9cfec940f2d7f661cd97651d10a8

Committed: https://skia.googlesource.com/skia/+/9bb7539a59ab15749fe26fecfec05330cffae684

[Rémi Piotaix, 2014-09-29 20:06:38]

piotaixr@chromium.org changed reviewers:
+ bsalomon@chromium.org, junov@chromium.org, reed@google.com

[Rémi Piotaix, 2014-09-29 20:06:47]

PTAL

[Rémi Piotaix, 2014-09-29 22:13:34]

On 2014/09/29 20:06:47, Rémi Piotaix wrote:
> PTAL

Issue updated, now depends on https://codereview.chromium.org/614773004 for
tests

[reed1, 2014-10-01 14:12:39]

lgtm w/ request for comments

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeRead.cpp
File src/pipe/SkGPipeRead.cpp (right):

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeRead.cpp...
src/pipe/SkGPipeRead.cpp:657: SkAutoTUnref<const SkImage> image
(static_cast<const SkImage*>(reader->readPtr()));
// Balances call to ref() in SkGPipeWrite

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeRead.cpp...
src/pipe/SkGPipeRead.cpp:671: SkAutoTUnref<const SkImage> image
(static_cast<const SkImage*>(reader->readPtr()));
// Balances call to ref() in SkGPipeWrite

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeWrite.cpp
File src/pipe/SkGPipeWrite.cpp (right):

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeWrite.cp...
src/pipe/SkGPipeWrite.cpp:839: if (is_cross_process(fFlags)){
// We call the inherited because ... ?

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeWrite.cp...
src/pipe/SkGPipeWrite.cpp:855: if (is_cross_process(fFlags)){
// We call the inherited because ... ?

[Rémi Piotaix, 2014-10-01 19:29:58]

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeRead.cpp
File src/pipe/SkGPipeRead.cpp (right):

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeRead.cpp...
src/pipe/SkGPipeRead.cpp:657: SkAutoTUnref<const SkImage> image
(static_cast<const SkImage*>(reader->readPtr()));
On 2014/10/01 14:12:39, reed1 wrote:
> // Balances call to ref() in SkGPipeWrite

Done.

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeRead.cpp...
src/pipe/SkGPipeRead.cpp:671: SkAutoTUnref<const SkImage> image
(static_cast<const SkImage*>(reader->readPtr()));
On 2014/10/01 14:12:39, reed1 wrote:
> // Balances call to ref() in SkGPipeWrite

Done.

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeWrite.cpp
File src/pipe/SkGPipeWrite.cpp (right):

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeWrite.cp...
src/pipe/SkGPipeWrite.cpp:839: if (is_cross_process(fFlags)){
On 2014/10/01 14:12:39, reed1 wrote:
> // We call the inherited because ... ?

Done.

https://codereview.chromium.org/613673005/diff/20001/src/pipe/SkGPipeWrite.cp...
src/pipe/SkGPipeWrite.cpp:855: if (is_cross_process(fFlags)){
On 2014/10/01 14:12:39, reed1 wrote:
> // We call the inherited because ... ?

Done.

[reed1, 2014-10-01 19:49:39]

Perhaps we can reference https://code.google.com/p/skia/issues/detail?id=2985 as
part of the // we have for having to send images cross-process.

lgtm

[Rémi Piotaix, 2014-10-16 18:48:27]

The CQ bit was checked by piotaixr@chromium.org

[commit-bot: I haz the power, 2014-10-16 18:49:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/613673005/80001

[commit-bot: I haz the power, 2014-10-16 18:55:43]

Committed patchset #5 (id:80001) as 687732fe046c9cfec940f2d7f661cd97651d10a8

[rmistry, 2014-10-17 13:18:27]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/658293004/ by rmistry@google.com.

The reason for reverting is: Trying to fix DEPS roll failure:
https://codereview.chromium.org/660113002/

Link to failing builds:
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2....

[rmistry, 2014-10-17 14:18:05]

On 2014/10/17 13:18:27, rmistry wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/658293004/ by mailto:rmistry@google.com.
> 
> The reason for reverting is: Trying to fix DEPS roll failure:
> https://codereview.chromium.org/660113002/
> 
> Link to failing builds:
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2....

Update:
Looks like this CL was in fact responsible for the linux_blink_{rel,dbg}
failures.
The DEPS roll after the revert looks good:
https://codereview.chromium.org/666463002/

[rmistry, 2014-10-17 14:34:17]

On 2014/10/17 14:18:05, rmistry wrote:
> On 2014/10/17 13:18:27, rmistry wrote:
> > A revert of this CL (patchset #5 id:80001) has been created in
> > https://codereview.chromium.org/658293004/ by mailto:rmistry@google.com.
> > 
> > The reason for reverting is: Trying to fix DEPS roll failure:
> > https://codereview.chromium.org/660113002/
> > 
> > Link to failing builds:
> >
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...
> >
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2....
> 
> Update:
> Looks like this CL was in fact responsible for the linux_blink_{rel,dbg}
> failures.
> The DEPS roll after the revert looks good:
> https://codereview.chromium.org/666463002/

Filed http://code.google.com/p/skia/issues/detail?id=3035 to help track this.

[Rémi Piotaix, 2014-10-22 15:49:25]

The CQ bit was checked by piotaixr@chromium.org

[Rémi Piotaix, 2014-10-22 15:49:29]

The CQ bit was unchecked by piotaixr@chromium.org

[Rémi Piotaix, 2014-10-22 17:54:23]

The CQ bit was checked by piotaixr@chromium.org

[commit-bot: I haz the power, 2014-10-22 17:54:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/613673005/140001

[commit-bot: I haz the power, 2014-10-22 18:02:42]

Committed patchset #8 (id:140001) as 9bb7539a59ab15749fe26fecfec05330cffae684

[Rémi Piotaix, 2014-11-04 20:11:35]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/705633002/ by piotaixr@chromium.org.

The reason for reverting is: The patch is breaking the telemetry blink build on
some windows configurations.

[reed1, 2014-11-04 20:45:49]

On 2014/11/04 20:11:35, Rémi Piotaix wrote:
> A revert of this CL (patchset #8 id:140001) has been created in
> https://codereview.chromium.org/705633002/ by mailto:piotaixr@chromium.org.
> 
> The reason for reverting is: The patch is breaking the telemetry blink build
on
> some windows configurations.

Can we capture the failures in a bug somewhere. It will be nice to actually land
this CL (or a variant of it)