Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 705593002: Refactor DrawTarget and GPU to be independent (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@early_clip
Project:
skia
Visibility:
Public.

Description

Refactor DrawTarget and GPU to be independent BUG=skia: Committed: https://skia.googlesource.com/skia/+/3322fa432a96fdc94d54f2475faf918dfa05b919

Patch Set 1 #

Patch Set 2 : rebase on master #

Patch Set 3 : more cleanup #

Patch Set 4 : more tidying #

Total comments: 1

Patch Set 5 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -147 lines) Patch
M src/gpu/GrContext.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 5 chunks +72 lines, -71 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 10 chunks +206 lines, -23 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 10 chunks +198 lines, -21 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 10 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
joshualitt
6 years, 1 month ago (2014-11-06 15:27:26 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/705593002/diff/60001/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (left): https://codereview.chromium.org/705593002/diff/60001/src/gpu/GrContext.cpp#oldcode216 src/gpu/GrContext.cpp:216: fGpu->purgeResources(); w00t
6 years, 1 month ago (2014-11-07 15:18:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705593002/60001
6 years, 1 month ago (2014-11-07 16:31:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705593002/80001
6 years, 1 month ago (2014-11-07 16:40:24 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 16:48:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/3322fa432a96fdc94d54f2475faf918dfa05b919

Powered by Google App Engine
This is Rietveld 408576698