Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 705553003: Avoid traversing classes when looking for circular references in typedefs. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Avoid traversing classes when looking for circular references in typedefs. BUG=dartbug.com/19459 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -38 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 4 chunks +8 lines, -37 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-05 00:14:54 UTC) #2
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-05 00:56:15 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-05 16:59:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41525 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698