Remove GrResourceKey from GrResourceCache

Remove all knowledge of resource keys from the legacy cache.

BUG=skia:2889
Committed: https://skia.googlesource.com/skia/+/6d4488c5e03010c94200b3706631d34ec3201411

[bsalomon, 2014-11-10 18:37:20]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2014-11-10 18:38:52]

https://codereview.chromium.org/705413002/diff/20001/src/gpu/GrResourceCache.cpp
File src/gpu/GrResourceCache.cpp (right):

https://codereview.chromium.org/705413002/diff/20001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.cpp:251: // TODO: Implement this in GrResourceCache2.
I won't land this until there is a follow up CL ready that does this.

https://codereview.chromium.org/705413002/diff/60001/src/gpu/GrResourceCache.cpp
File src/gpu/GrResourceCache.cpp (right):

https://codereview.chromium.org/705413002/diff/60001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.cpp:250: // TODO: Implement this in GrResourceCache2.
I won't land this until there is a follow up CL ready that does this. The CLs
were getting big enough that I thought it made sense to break them up.

[robertphillips, 2014-11-11 15:04:44]

https://codereview.chromium.org/705413002/diff/60001/src/gpu/GrGpuResource.cpp
File src/gpu/GrGpuResource.cpp (right):

https://codereview.chromium.org/705413002/diff/60001/src/gpu/GrGpuResource.cp...
src/gpu/GrGpuResource.cpp:88: if (fContentKeySet) {
Assert in here?

[bsalomon, 2014-11-11 15:17:22]

I'm going to take back my promise to not land this until the mailbox stuff is
reintroduced. Seems like it is farther away than I originally thought and I'd
like to land these patches over time rather than all at once.

https://codereview.chromium.org/705413002/diff/60001/src/gpu/GrGpuResource.cpp
File src/gpu/GrGpuResource.cpp (right):

https://codereview.chromium.org/705413002/diff/60001/src/gpu/GrGpuResource.cp...
src/gpu/GrGpuResource.cpp:88: if (fContentKeySet) {
On 2014/11/11 15:04:44, robertphillips wrote:
> Assert in here?

Unit tests exercise this behavior.

[bsalomon, 2014-11-11 15:17:43]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-11-11 15:18:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/705413002/60001

[commit-bot: I haz the power, 2014-11-11 15:18:29]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-11 21:18 UTC

[robertphillips, 2014-11-11 15:23:32]

lgtm

[robertphillips, 2014-11-11 15:23:41]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2014-11-11 15:24:03]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-11-11 15:24:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/705413002/60001

[commit-bot: I haz the power, 2014-11-11 15:27:23]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6d4488c5e03010c94200b3706631d34ec3201411