content: Enable the RendererScheduler by default.

content: Enable the RendererScheduler by default.

BUG=391005
Committed: https://crrev.com/ddff43275d41109c2acb07aa6dd52e114bafca11
Cr-Commit-Position: refs/heads/master@{#303625}

[rmcilroy, 2014-11-06 00:43:26]

rmcilroy@chromium.org changed reviewers:
+ skyostil@chromium.org

[rmcilroy, 2014-11-06 00:43:27]

This CL will need to wait for Alex's two hookup CLs listed below to land before
we can land it:

https://codereview.chromium.org/692483002/
https://codereview.chromium.org/690703002/

[Sami, 2014-11-07 16:22:05]

Yay, lgtm!

[rmcilroy, 2014-11-07 23:35:43]

rmcilroy@chromium.org changed reviewers:
+ sievers@chromium.org

[rmcilroy, 2014-11-07 23:35:43]

Thanks Sami.

Daniel, could you review for OWNERS please?

[Sami, 2014-11-10 12:46:58]

On further deliberation, let's figure out if we can avoid doing this for WebView
initially (crbug.com/431598). It doesn't look like we can append the flag to the
renderer command line (I think -- since we don't have a renderer process), but
maybe there's another way.

[rmcilroy, 2014-11-10 14:06:53]

On 2014/11/10 12:46:58, Sami wrote:
> On further deliberation, let's figure out if we can avoid doing this for
WebView
> initially (crbug.com/431598). It doesn't look like we can append the flag to
the
> renderer command line (I think -- since we don't have a renderer process), but
> maybe there's another way.

I uploaded a CL to add the command line flag to disable the scheduler on webview
via the aw_main_delegate at https://codereview.chromium.org/694993005/

[Sami, 2014-11-10 15:00:53]

Great, that was the bit I was trying to find. This patch still lgtm if we land
it after that one.

[no sievers, 2014-11-10 20:52:05]

lgtm

[rmcilroy, 2014-11-11 10:18:59]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2014-11-11 10:19:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/704933002/1

[commit-bot: I haz the power, 2014-11-11 11:05:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-11 11:06:33]

Patchset 1 (id:??) landed as
https://crrev.com/ddff43275d41109c2acb07aa6dd52e114bafca11
Cr-Commit-Position: refs/heads/master@{#303625}

[sof, 2014-11-11 14:25:11]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2014-11-11 14:25:12]

This seemingly broke a LayoutTest,

 
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(deps...
 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...

It goes away if I revert locally.

[Stephen White, 2014-11-11 14:39:15]

On 2014/11/11 14:25:12, sof wrote:
> This seemingly broke a LayoutTest,
> 
>  
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(deps...
>  
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...
> 
> It goes away if I revert locally.

Also may be responsible for the following failures on Debug bots:

inspector/console/console-format.html
http/tests/appcache/fallback.html

e.g.,
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/b...

I've speculatively reverted the change (r303644). Please run the layout tests in
Debug prior to re-landing.

[rmcilroy, 2014-11-11 14:53:50]

On 2014/11/11 14:39:15, Stephen White wrote:
> On 2014/11/11 14:25:12, sof wrote:
> > This seemingly broke a LayoutTest,
> > 
> >  
> >
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(deps...
> >  
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...
> > 
> > It goes away if I revert locally.
> 
> Also may be responsible for the following failures on Debug bots:
> 
> inspector/console/console-format.html
> http/tests/appcache/fallback.html
> 
> e.g.,
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/b...
> 
> I've speculatively reverted the change (r303644). Please run the layout tests
in
> Debug prior to re-landing.

Thanks for reverting.  I've opened a bug to track this at crbug.com/432129.  We
will make sure the layout tests are passing in Debug before re-landing.

[Stephen White, 2014-11-11 15:06:05]

On 2014/11/11 14:53:50, rmcilroy wrote:
> On 2014/11/11 14:39:15, Stephen White wrote:
> > On 2014/11/11 14:25:12, sof wrote:
> > > This seemingly broke a LayoutTest,
> > > 
> > >  
> > >
> >
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(deps...
> > >  
> > >
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...
> > > 
> > > It goes away if I revert locally.
> > 
> > Also may be responsible for the following failures on Debug bots:
> > 
> > inspector/console/console-format.html
> > http/tests/appcache/fallback.html
> > 
> > e.g.,
> >
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/b...
> > 
> > I've speculatively reverted the change (r303644). Please run the layout
tests
> in
> > Debug prior to re-landing.
> 
> Thanks for reverting.  I've opened a bug to track this at crbug.com/432129. 
We
> will make sure the layout tests are passing in Debug before re-landing.

Also possibly affected:
http/tests/loading/simple-subframe.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...