Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 694993005: aw: Disable blink scheduler on the Android WebView. (Closed)

Created:
6 years, 1 month ago by rmcilroy
Modified:
6 years, 1 month ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org, Sami, jdduke (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

aw: Disable blink scheduler on the Android WebView. We need to hook up input handling through the blink scheduler before we can enable it for WebView, so disable it for now on Android WebView until we fix this. BUG=431598 Committed: https://crrev.com/a229c4cacb8932e8fe574791333325500ac6339e Cr-Commit-Position: refs/heads/master@{#303611}

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
rmcilroy
Martin: Could you please take a look, thanks.
6 years, 1 month ago (2014-11-10 14:03:28 UTC) #2
mkosiba (inactive)
lgtm
6 years, 1 month ago (2014-11-10 21:54:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694993005/20001
6 years, 1 month ago (2014-11-10 21:57:30 UTC) #6
boliu
Wait.. On the bug, Sami said it's only for benchmarking. If so, can we just ...
6 years, 1 month ago (2014-11-10 21:58:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/79644) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/84572) win8_chromium_rel ...
6 years, 1 month ago (2014-11-10 22:02:42 UTC) #9
rmcilroy
On 2014/11/10 21:58:57, boliu wrote: > Wait.. On the bug, Sami said it's only for ...
6 years, 1 month ago (2014-11-10 22:06:11 UTC) #10
boliu
On 2014/11/10 22:06:11, rmcilroy wrote: > On 2014/11/10 21:58:57, boliu wrote: > > Wait.. On ...
6 years, 1 month ago (2014-11-10 22:13:13 UTC) #11
rmcilroy
> Should fix that bug asap then. Can we agree to fix it say by ...
6 years, 1 month ago (2014-11-11 07:42:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694993005/40001
6 years, 1 month ago (2014-11-11 07:44:24 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-11 08:28:43 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 08:29:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a229c4cacb8932e8fe574791333325500ac6339e
Cr-Commit-Position: refs/heads/master@{#303611}

Powered by Google App Engine
This is Rietveld 408576698