Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 704923003: start again on Sk4x with portable version and unit tests (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

start again on Sk4x with portable version and unit tests work on tests CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot BUG=skia: Committed: https://skia.googlesource.com/skia/+/5da116f920c80821ebc039da3f633a74ad0c7b57

Patch Set 1 #

Patch Set 2 : finish first pass on tests #

Patch Set 3 : memcpy #

Total comments: 2

Patch Set 4 : int32_t #

Patch Set 5 : windows warnings #

Patch Set 6 : windows, do you like this? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -0 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A src/core/Sk4x.h View 1 2 3 1 chunk +70 lines, -0 lines 0 comments Download
A src/core/Sk4x_portable.h View 1 2 3 4 5 1 chunk +101 lines, -0 lines 0 comments Download
A tests/Sk4xTest.cpp View 1 2 3 4 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704923003/20001
6 years, 1 month ago (2014-11-07 17:35:53 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-07 17:35:54 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/495)
6 years, 1 month ago (2014-11-07 17:39:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704923003/30005
6 years, 1 month ago (2014-11-07 17:42:53 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-07 17:42:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/675)
6 years, 1 month ago (2014-11-07 17:59:34 UTC) #10
reed1
lgtm https://codereview.chromium.org/704923003/diff/30005/src/core/Sk4x.h File src/core/Sk4x.h (right): https://codereview.chromium.org/704923003/diff/30005/src/core/Sk4x.h#newcode12 src/core/Sk4x.h:12: typedef Sk4x<int> Sk4i; just for documentation purpose, should ...
6 years, 1 month ago (2014-11-07 18:01:23 UTC) #12
mtklein
https://codereview.chromium.org/704923003/diff/30005/src/core/Sk4x.h File src/core/Sk4x.h (right): https://codereview.chromium.org/704923003/diff/30005/src/core/Sk4x.h#newcode12 src/core/Sk4x.h:12: typedef Sk4x<int> Sk4i; On 2014/11/07 18:01:23, reed1 wrote: > ...
6 years, 1 month ago (2014-11-07 18:07:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704923003/70001
6 years, 1 month ago (2014-11-07 18:13:15 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/679)
6 years, 1 month ago (2014-11-07 18:16:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704923003/90001
6 years, 1 month ago (2014-11-07 18:20:14 UTC) #19
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 1 month ago (2014-11-08 00:20:21 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704923003/90001
6 years, 1 month ago (2014-11-08 00:32:11 UTC) #23
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 1 month ago (2014-11-08 06:32:23 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704923003/90001
6 years, 1 month ago (2014-11-10 15:11:21 UTC) #27
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 1 month ago (2014-11-11 09:11:42 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704923003/90001
6 years, 1 month ago (2014-11-11 14:16:32 UTC) #31
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 14:16:49 UTC) #32
Message was sent while issue was closed.
Committed patchset #6 (id:90001) as
https://skia.googlesource.com/skia/+/5da116f920c80821ebc039da3f633a74ad0c7b57

Powered by Google App Engine
This is Rietveld 408576698