Issue 704833002: Switch test_sky to sky_server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 704833002: Switch test_sky to sky_server (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Switch test_sky to sky_server Adam did this in: https://codereview.chromium.org/699333002 But later reverted in: https://codereview.chromium.org/692333007 The problem was that the path to sky_server was being computed relative to the sky directory instead of being absolute, so when the bots tried to run test_sky from the root mojo directory instead of mojo/sky they failed. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/595649ed247273a60f6681ef6abed54453cd971c

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -25 lines)			Patch
M	sky/tests/parser/script-expected.txt	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	sky/tests/services/network.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/services/network-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/services/xhr.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tools/webkitpy/common/webkit_finder.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tools/webkitpy/layout_tests/port/base.py	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/port/driver.py	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Total messages: 1 (0 generated)

eseidel

6 years, 1 month ago (2014-11-05 21:08:53 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
595649ed247273a60f6681ef6abed54453cd971c (presubmit successful).