Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 699333002: Switch test_sky from apache to sky_server (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
ojan, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, Dirk Pranke
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Switch test_sky from apache to sky_server After this CL, test_sky uses the same server as skydb. R=eseidel@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3bd10ff6c3e44b595cc87ced569a77e74dee8443

Patch Set 1 #

Patch Set 2 : Less printf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M sky/tests/parser/script-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M sky/tests/services/network.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/network-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/xhr.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/sky_server View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/base.py View 1 3 chunks +9 lines, -8 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/driver.py View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-11-05 00:25:39 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-11-05 00:35:39 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-05 00:42:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3bd10ff6c3e44b595cc87ced569a77e74dee8443 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698