Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 704563003: Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Turn on NVPR 4x MSAA by default when supported in DM and nanobench. This brings DM and nanobench's default configs in line with GM's. BUG=skia: Committed: https://skia.googlesource.com/skia/+/31f88675718966bbb7f09718b40de10c7e214739

Patch Set 1 #

Patch Set 2 : fix dm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M dm/DMGpuGMTask.cpp View 1 2 chunks +7 lines, -1 line 0 comments Download
M dm/DMGpuSupport.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
mtklein
6 years, 1 month ago (2014-11-05 16:44:05 UTC) #2
bsalomon
lgtm
6 years, 1 month ago (2014-11-05 19:52:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704563003/20001
6 years, 1 month ago (2014-11-05 20:20:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 31f88675718966bbb7f09718b40de10c7e214739
6 years, 1 month ago (2014-11-05 20:28:29 UTC) #6
egdaniel
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/693933004/ by egdaniel@google.com. ...
6 years, 1 month ago (2014-11-05 22:20:17 UTC) #7
Kimmo Kinnunen
On 2014/11/05 22:20:17, egdaniel wrote: > A revert of this CL (patchset #2 id:20001) has ...
6 years, 1 month ago (2014-11-11 07:14:01 UTC) #8
Kimmo Kinnunen
On 2014/11/11 07:14:01, Kimmo Kinnunen wrote: > Hey, I could try to fix the underlying ...
6 years, 1 month ago (2014-11-11 12:51:49 UTC) #9
bsalomon
On 2014/11/11 12:51:49, Kimmo Kinnunen wrote: > On 2014/11/11 07:14:01, Kimmo Kinnunen wrote: > > ...
6 years, 1 month ago (2014-11-11 12:54:47 UTC) #10
mtklein
6 years, 1 month ago (2014-11-11 13:11:59 UTC) #11
Message was sent while issue was closed.
On 2014/11/11 12:54:47, bsalomon wrote:
> On 2014/11/11 12:51:49, Kimmo Kinnunen wrote:
> > On 2014/11/11 07:14:01, Kimmo Kinnunen wrote:
> > > Hey, I could try to fix the underlying problem. I wonder which test caused
> the
> > > timeout?
> > 
> > Nevermind, if it was path_hairline_{small,big}_AA_conic, I found it.
> 
> I'm pretty sure it was those tests.

Right.  IIRC, the bench was taking roughly a constant time to run (drawing
nothing) no matter how nanobench tuned the loops.

Powered by Google App Engine
This is Rietveld 408576698