Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 704523002: Fix gamepad mapping for Shield and Xbox controllers (Closed)

Created:
6 years, 1 month ago by sshelke
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix gamepad mapping for Shield and Xbox controllers This CL maps trigger axes to bottom shoulder buttons and trigger buttons to top shoulder buttons for Shield and Xbox controllers. BUG=421833 Committed: https://crrev.com/3cfb77853ed97cfc22d4c9428c18837ddcf92a1a Cr-Commit-Position: refs/heads/master@{#306697}

Patch Set 1 #

Patch Set 2 : Fix gamepad mapping for Shield and Xbox controllers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/GamepadMappings.java View 1 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
sshelke
6 years, 1 month ago (2014-11-04 11:15:42 UTC) #2
sshelke
On 2014/11/04 11:15:42, sshelke wrote: b.kelemen,jdd Could you please review the change?
6 years, 1 month ago (2014-11-17 07:46:47 UTC) #3
kbalazs
On 2014/11/17 07:46:47, sshelke wrote: > On 2014/11/04 11:15:42, sshelke wrote: > b.kelemen,jdd > Could ...
6 years ago (2014-11-25 18:04:50 UTC) #5
kbalazs
@aurimas, could you take a look? Thanks.
6 years ago (2014-11-25 18:06:01 UTC) #7
aurimas (slooooooooow)
lgtm
6 years ago (2014-11-25 18:10:18 UTC) #8
aurimas (slooooooooow)
On 2014/11/25 18:10:18, aurimas wrote: > lgtm +jdduke as FYI
6 years ago (2014-11-25 18:11:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704523002/1
6 years ago (2014-11-26 07:45:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/20772)
6 years ago (2014-11-26 08:07:21 UTC) #14
sshelke
Build was failed due to change https://codereview.chromium.org/617103007. This CL has changed shoulder button and trigger ...
6 years ago (2014-11-27 08:55:35 UTC) #16
aurimas (slooooooooow)
still LGTM
6 years ago (2014-12-03 21:48:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704523002/20001
6 years ago (2014-12-03 21:51:09 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 22:45:23 UTC) #20
commit-bot: I haz the power
6 years ago (2014-12-03 22:46:42 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cfb77853ed97cfc22d4c9428c18837ddcf92a1a
Cr-Commit-Position: refs/heads/master@{#306697}

Powered by Google App Engine
This is Rietveld 408576698