Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 704493002: Revert "Sdch view for net-internals" (Closed)

Created:
6 years, 1 month ago by tzik
Modified:
6 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, eroman, arv+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Sdch view for net-internals" The CL seems to break NetInternalsTest.netInternalsSdchViewBlacklistNonSdch in browser_tests. Its error log is available here: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/15797/ http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/15797/steps/browser_tests/logs/netInternalsSdchViewBlacklistNonSdch This reverts commit fe89e5a5a23f3323201d3586b2ec77174f042158. https://codereview.chromium.org/423813002/ BUG= TBR=mmenke, rdsmith, jwd, baranovich, NOTRY=True Committed: https://crrev.com/2f98de3083ddacbb62eeda7f7ef0b7cbe9048d02 Cr-Commit-Position: refs/heads/master@{#302582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -1257 lines) Patch
M chrome/browser/resources/net_internals/browser_bridge.js View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/net_internals/index.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/net_internals/index.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/net_internals/log_view_painter.js View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/resources/net_internals/main.js View 4 chunks +0 lines, -15 lines 0 comments Download
D chrome/browser/resources/net_internals/sdch_view.html View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/resources/net_internals/sdch_view.js View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/sdch/dict View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/sdch/non-sdch.html View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/sdch/non-sdch.html.mock-http-headers View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/sdch/page.html View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/sdch/page.html.mock-http-headers View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/webui/net_internals/log_util.js View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/webui/net_internals/main.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/webui/net_internals/net_internals_test.js View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webui/net_internals/sdch_view.js View 1 chunk +0 lines, -214 lines 0 comments Download
M net/base/net_info_source_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/net_log_event_type_list.h View 1 chunk +0 lines, -35 lines 0 comments Download
M net/base/net_log_util.cc View 4 chunks +0 lines, -31 lines 0 comments Download
M net/base/sdch_dictionary_fetcher.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/base/sdch_dictionary_fetcher.cc View 7 chunks +14 lines, -29 lines 0 comments Download
M net/base/sdch_dictionary_fetcher_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/base/sdch_manager.h View 13 chunks +129 lines, -46 lines 0 comments Download
M net/base/sdch_manager.cc View 19 chunks +139 lines, -174 lines 0 comments Download
M net/base/sdch_manager_unittest.cc View 14 chunks +61 lines, -72 lines 0 comments Download
D net/base/sdch_net_log_params.h View 1 chunk +0 lines, -31 lines 0 comments Download
D net/base/sdch_net_log_params.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D net/base/sdch_problem_code_list.h View 1 chunk +0 lines, -127 lines 0 comments Download
D net/base/sdch_problem_codes.h View 1 chunk +0 lines, -20 lines 0 comments Download
M net/filter/filter.h View 2 chunks +1 line, -5 lines 0 comments Download
M net/filter/filter.cc View 6 chunks +20 lines, -21 lines 0 comments Download
M net/filter/mock_filter_context.h View 3 chunks +0 lines, -4 lines 0 comments Download
M net/filter/mock_filter_context.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/filter/sdch_filter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/filter/sdch_filter.cc View 15 chunks +38 lines, -92 lines 0 comments Download
M net/filter/sdch_filter_unittest.cc View 5 chunks +17 lines, -14 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 6 chunks +22 lines, -67 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +3 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tzik
PTL later.
6 years, 1 month ago (2014-11-04 06:35:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704493002/1
6 years, 1 month ago (2014-11-04 06:37:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 06:38:36 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 06:39:10 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2f98de3083ddacbb62eeda7f7ef0b7cbe9048d02
Cr-Commit-Position: refs/heads/master@{#302582}

Powered by Google App Engine
This is Rietveld 408576698