Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 704453002: Allow extension function call quota to be un-throttled. (Closed)

Created:
6 years, 1 month ago by not at google - send to devlin
Modified:
6 years, 1 month ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow extension function call quota to be un-throttled. For example, previously if chrome.storage.sync.set was called more than 1000 times in an hour it would be throttled forever (until Chrome restart). Now that quota is restored every hour. BUG=406406 R=zea@chromium.org Committed: https://crrev.com/2610ea15b9d6f97ab6fd399d67b2e13fb79fce56 Cr-Commit-Position: refs/heads/master@{#302716}

Patch Set 1 #

Patch Set 2 : betterify #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -33 lines) Patch
M extensions/browser/quota_service.h View 1 2 2 chunks +3 lines, -12 lines 0 comments Download
M extensions/browser/quota_service.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M extensions/browser/quota_service_unittest.cc View 1 2 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
not at google - send to devlin
6 years, 1 month ago (2014-11-04 00:57:52 UTC) #1
Nicolas Zea
https://codereview.chromium.org/704453002/diff/20001/extensions/browser/quota_service.h File extensions/browser/quota_service.h (right): https://codereview.chromium.org/704453002/diff/20001/extensions/browser/quota_service.h#newcode71 extensions/browser/quota_service.h:71: // ones that consistently violate, so we'll converge to ...
6 years, 1 month ago (2014-11-04 20:33:10 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/704453002/diff/20001/extensions/browser/quota_service.h File extensions/browser/quota_service.h (right): https://codereview.chromium.org/704453002/diff/20001/extensions/browser/quota_service.h#newcode71 extensions/browser/quota_service.h:71: // ones that consistently violate, so we'll converge to ...
6 years, 1 month ago (2014-11-04 22:07:25 UTC) #3
Nicolas Zea
LGTM
6 years, 1 month ago (2014-11-04 22:08:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704453002/40001
6 years, 1 month ago (2014-11-04 22:12:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8563)
6 years, 1 month ago (2014-11-04 23:30:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704453002/40001
6 years, 1 month ago (2014-11-04 23:52:50 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-05 00:18:25 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 00:18:59 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2610ea15b9d6f97ab6fd399d67b2e13fb79fce56
Cr-Commit-Position: refs/heads/master@{#302716}

Powered by Google App Engine
This is Rietveld 408576698