Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: extensions/browser/quota_service_unittest.cc

Issue 704453002: Allow extension function call quota to be un-throttled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/quota_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/quota_service_unittest.cc
diff --git a/extensions/browser/quota_service_unittest.cc b/extensions/browser/quota_service_unittest.cc
index b33910a9d867580515388682f6ffd4f096f504d2..193aa34dd5f23f4964547f65ec7e15b2d6408816 100644
--- a/extensions/browser/quota_service_unittest.cc
+++ b/extensions/browser/quota_service_unittest.cc
@@ -287,9 +287,8 @@ TEST_F(QuotaServiceTest, MultipleFunctionsDontInterfere) {
kStartTime + TimeDelta::FromSeconds(15)));
}
-TEST_F(QuotaServiceTest, ViolatorsWillBeViolators) {
+TEST_F(QuotaServiceTest, ViolatorsWillBeForgiven) {
scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo"));
- scoped_refptr<MockFunction> g(new TimedLimitMockFunction("bar"));
base::ListValue arg;
arg.Append(new base::FundamentalValue(1));
EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &arg, kStartTime));
@@ -304,16 +303,30 @@ TEST_F(QuotaServiceTest, ViolatorsWillBeViolators) {
&arg,
kStartTime + TimeDelta::FromSeconds(15)));
- // We don't allow this extension to use quota limited functions even if they
- // wait a while.
- EXPECT_NE(
- "",
- service_->Assess(
- extension_a_, f.get(), &arg, kStartTime + TimeDelta::FromDays(1)));
- EXPECT_NE(
- "",
- service_->Assess(
- extension_a_, g.get(), &arg, kStartTime + TimeDelta::FromDays(1)));
+ // Waiting a while will give the extension access to the function again.
+ EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &arg,
+ kStartTime + TimeDelta::FromDays(1)));
+
+ // And lose it again soon after.
+ EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &arg,
+ kStartTime + TimeDelta::FromDays(1) +
+ TimeDelta::FromSeconds(10)));
+ EXPECT_NE("", service_->Assess(extension_a_, f.get(), &arg,
+ kStartTime + TimeDelta::FromDays(1) +
+ TimeDelta::FromSeconds(15)));
+
+ // Going further over quota should continue to fail within this time period,
+ // but still all restored later.
+ EXPECT_NE("", service_->Assess(extension_a_, f.get(), &arg,
+ kStartTime + TimeDelta::FromDays(1) +
+ TimeDelta::FromSeconds(20)));
+ EXPECT_NE("", service_->Assess(extension_a_, f.get(), &arg,
+ kStartTime + TimeDelta::FromDays(1) +
+ TimeDelta::FromSeconds(25)));
+
+ // Like now.
+ EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &arg,
+ kStartTime + TimeDelta::FromDays(2)));
}
} // namespace extensions
« no previous file with comments | « extensions/browser/quota_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698